RE: [PATCH v3 0/4] Re-use device management code fragments

From: Avri Altman
Date: Sat Mar 23 2024 - 06:06:41 EST


Martin,
Can you take a look at this?
I have a follow-up series waiting.

Thanks,
Avri

> v2->v3:
> - 2/4 - Clarify commit log (Bean)
> - 4/4 - pass cmd_type to ufshcd_prepare_req_desc_hdr (Bean)
>
> v1->v2:
> - Attend Bart's comments
>
>
> Device management commands are constructed for query commands that are
> being issued by the driver, but also for raw device management commands
> originated by the bsg module, and recently, by the advanced rpmb handler.
> Thus, the same code fragments, e.g. locking, composing the command,
> composing the upiu etc., appear over and over. Remove those duplications.
> Theoretically, there should be no functional change.
>
> Avri Altman (4):
> scsi: ufs: Re-use device management locking code
> scsi: ufs: Re-use exec_dev_cmd
> scsi: ufs: Re-use compose_dev_cmd
> scsi: ufs: Re-use compose_devman_upiu
>
> drivers/ufs/core/ufshcd.c | 204 ++++++++++++++++----------------------
> include/ufs/ufshci.h | 2 +-
> 2 files changed, 87 insertions(+), 119 deletions(-)
>
> --
> 2.42.0