Re: [PATCH V3] irqchip/loongson-pch-pic: Update interrupt registration policy

From: Thomas Gleixner
Date: Sat Mar 23 2024 - 16:05:28 EST


Tianyang!

On Fri, Mar 22 2024 at 18:14, Tianyang Zhang wrote:

Please do not top-post. See the 'Top-posting' chapter in:
https://people.kernel.org/tglx/notes-about-netiquette

> Regarding "WHY", my understanding is that a convincing reason is needed
> to explain the necessity of this patch.

Yes.

> If so, can the last paragraph "This will be more conducive to fully
> utilizing existing vectors to support more devices."
>
> be considered a simple explanation?

Kinda, but ideally you describe it in a way that there is context for
the reader. Like this:

The fixed mapping between the LS7A interrupt source and the HT
interrupt vector prevents the utilization of the full interrupt vector
space which limits the number of devices in a system

Replace the fixed mapping with a dynamic mapping which allocates a
vector when an interrupt source is set up. This avoids that unused
sources prevent vectors from being used for other devices.

See?

Thanks,

tglx