Re: [syzbot] [bpf?] UBSAN: array-index-out-of-bounds in bpf_prog_select_runtime

From: syzbot
Date: Sat Mar 23 2024 - 18:10:11 EST


Hello,

syzbot tried to test the proposed patch but the build/boot failed:

connector registered
[ 9.572858][ T1] [drm] Initialized vgem 1.0.0 20120112 for vgem on minor 0
[ 9.584256][ T1] [drm] Initialized vkms 1.0.0 20180514 for vkms on minor 1
[ 9.680087][ T1] Console: switching to colour frame buffer device 128x48
[ 9.696560][ T1] platform vkms: [drm] fb0: vkmsdrmfb frame buffer device
[ 9.698211][ T1] usbcore: registered new interface driver udl
[ 9.793530][ T1] brd: module loaded
[ 9.913667][ T1] loop: module loaded
[ 10.101090][ T1] zram: Added device: zram0
[ 10.114153][ T1] null_blk: disk nullb0 created
[ 10.115012][ T1] null_blk: module loaded
[ 10.117246][ T1] Guest personality initialized and is inactive
[ 10.119788][ T1] VMCI host device registered (name=vmci, major=10, minor=118)
[ 10.121119][ T1] Initialized host personality
[ 10.122385][ T1] usbcore: registered new interface driver rtsx_usb
[ 10.124441][ T1] usbcore: registered new interface driver viperboard
[ 10.125799][ T1] usbcore: registered new interface driver dln2
[ 10.127995][ T1] usbcore: registered new interface driver pn533_usb
[ 10.138179][ T1] nfcsim 0.2 initialized
[ 10.140398][ T1] usbcore: registered new interface driver port100
[ 10.142027][ T1] usbcore: registered new interface driver nfcmrvl
[ 10.151644][ T1] Loading iSCSI transport class v2.0-870.
[ 10.171732][ T1] virtio_scsi virtio0: 1/0/0 default/read/poll queues
[ 10.186563][ T1] ------------[ cut here ]------------
[ 10.187348][ T1] refcount_t: decrement hit 0; leaking memory.
[ 10.188508][ T1] WARNING: CPU: 0 PID: 1 at lib/refcount.c:31 refcount_warn_saturate+0x1ed/0x210
[ 10.191432][ T1] Modules linked in:
[ 10.192019][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0-syzkaller-13182-g484193fecd2b-dirty #0
[ 10.193638][ T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
[ 10.195427][ T1] RIP: 0010:refcount_warn_saturate+0x1ed/0x210
[ 10.196395][ T1] Code: 8b e8 17 42 d2 fc 90 0f 0b 90 90 e9 c3 fe ff ff e8 e8 d2 0f fd c6 05 bb 02 4d 0b 01 90 48 c7 c7 80 e3 8e 8b e8 f4 41 d2 fc 90 <0f> 0b 90 90 e9 a0 fe ff ff 48 89 ef e8 72 fb 6a fd e9 44 fe ff ff
[ 10.199935][ T1] RSP: 0000:ffffc900000673c0 EFLAGS: 00010286
[ 10.201025][ T1] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff814fe149
[ 10.202204][ T1] RDX: ffff888016ec8000 RSI: ffffffff814fe156 RDI: 0000000000000001
[ 10.203507][ T1] RBP: ffff88814168f58c R08: 0000000000000001 R09: 0000000000000000
[ 10.204951][ T1] R10: 0000000000000000 R11: 0000000000000001 R12: ffff88814168f58c
[ 10.206164][ T1] R13: 0000000000000000 R14: 0000000006ae00b9 R15: ffff88801687a588
[ 10.208440][ T1] FS: 0000000000000000(0000) GS:ffff8880b9200000(0000) knlGS:0000000000000000
[ 10.210295][ T1] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 10.211544][ T1] CR2: ffff88823ffff000 CR3: 000000000d97a000 CR4: 00000000003506f0
[ 10.213262][ T1] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 10.214476][ T1] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 10.215639][ T1] Call Trace:
[ 10.216229][ T1] <TASK>
[ 10.216789][ T1] ? show_regs+0x8c/0xa0
[ 10.217525][ T1] ? __warn+0xe5/0x3c0
[ 10.218395][ T1] ? __wake_up_klogd.part.0+0x99/0xf0
[ 10.219772][ T1] ? refcount_warn_saturate+0x1ed/0x210
[ 10.220616][ T1] ? report_bug+0x3c0/0x580
[ 10.221279][ T1] ? handle_bug+0x3d/0x70
[ 10.221955][ T1] ? exc_invalid_op+0x17/0x50
[ 10.222793][ T1] ? asm_exc_invalid_op+0x1a/0x20
[ 10.224072][ T1] ? __warn_printk+0x199/0x350
[ 10.225145][ T1] ? __warn_printk+0x1a6/0x350
[ 10.225925][ T1] ? refcount_warn_saturate+0x1ed/0x210
[ 10.226934][ T1] __reset_page_owner+0x2ea/0x370
[ 10.227736][ T1] __free_pages_ok+0x5a9/0xbf0
[ 10.228415][ T1] ? __split_page_owner+0xdd/0x120
[ 10.229191][ T1] make_alloc_exact+0x165/0x260
[ 10.229917][ T1] vring_alloc_queue+0xc1/0x110
[ 10.230635][ T1] vring_alloc_queue_split+0x186/0x510
[ 10.231420][ T1] ? __pfx_vring_alloc_queue_split+0x10/0x10
[ 10.232251][ T1] ? kasan_save_stack+0x42/0x60
[ 10.232963][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.234590][ T1] vring_create_virtqueue_split+0xe8/0x280
[ 10.235665][ T1] ? __pfx_vp_notify+0x10/0x10
[ 10.236516][ T1] ? __pfx_vring_create_virtqueue_split+0x10/0x10
[ 10.237686][ T1] ? virtio_scsi_init+0x75/0x100
[ 10.238656][ T1] ? do_one_initcall+0x128/0x700
[ 10.239488][ T1] ? kernel_init_freeable+0x69d/0xca0
[ 10.240398][ T1] vring_create_virtqueue+0xd7/0x140
[ 10.241186][ T1] ? __pfx_vp_notify+0x10/0x10
[ 10.241965][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.243112][ T1] setup_vq+0x123/0x2f0
[ 10.243810][ T1] ? __pfx_vp_notify+0x10/0x10
[ 10.244761][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.245553][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.246547][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.247478][ T1] vp_setup_vq+0xb1/0x380
[ 10.248194][ T1] ? iowrite16+0x55/0x80
[ 10.249175][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.250422][ T1] vp_find_vqs_msix+0x661/0xe30
[ 10.251165][ T1] vp_find_vqs+0x58/0x560
[ 10.251947][ T1] virtscsi_init+0x459/0x9f0
[ 10.252881][ T1] ? __pfx_virtscsi_init+0x10/0x10
[ 10.253796][ T1] ? __pfx_default_calc_sets+0x10/0x10
[ 10.254568][ T1] ? ioread8+0x4e/0xa0
[ 10.255139][ T1] ? vp_get+0xf6/0x140
[ 10.255707][ T1] virtscsi_probe+0x3b2/0xdd0
[ 10.256452][ T1] ? __pfx_virtscsi_probe+0x10/0x10
[ 10.257363][ T1] ? trace_raw_output_sched_pi_setprio+0xad/0x150
[ 10.259318][ T1] ? vring_transport_features+0x49/0xb0
[ 10.260183][ T1] virtio_dev_probe+0x5ff/0x9b0
[ 10.260877][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 10.261663][ T1] really_probe+0x23e/0xa90
[ 10.262480][ T1] __driver_probe_device+0x1de/0x440
[ 10.263462][ T1] ? _raw_spin_unlock_irqrestore+0x52/0x80
[ 10.264576][ T1] driver_probe_device+0x4c/0x1b0
[ 10.265289][ T1] __driver_attach+0x283/0x580
[ 10.265950][ T1] ? __pfx___driver_attach+0x10/0x10
[ 10.266697][ T1] bus_for_each_dev+0x13c/0x1d0
[ 10.267364][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 10.268099][ T1] bus_add_driver+0x2ed/0x640
[ 10.268824][ T1] driver_register+0x15c/0x4b0
[ 10.269581][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 10.270424][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 10.271525][ T1] virtio_scsi_init+0x75/0x100
[ 10.272450][ T1] do_one_initcall+0x128/0x700
[ 10.273380][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 10.274148][ T1] ? trace_kmalloc+0x2d/0xe0
[ 10.274844][ T1] ? __kmalloc+0x218/0x440
[ 10.275566][ T1] kernel_init_freeable+0x69d/0xca0
[ 10.276467][ T1] ? __pfx_kernel_init+0x10/0x10
[ 10.277287][ T1] kernel_init+0x1c/0x2b0
[ 10.278215][ T1] ? __pfx_kernel_init+0x10/0x10
[ 10.279001][ T1] ret_from_fork+0x45/0x80
[ 10.279722][ T1] ? __pfx_kernel_init+0x10/0x10
[ 10.280617][ T1] ret_from_fork_asm+0x1a/0x30
[ 10.281685][ T1] </TASK>
[ 10.282111][ T1] Kernel panic - not syncing: kernel: panic_on_warn set ...
[ 10.283173][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0-syzkaller-13182-g484193fecd2b-dirty #0
[ 10.284676][ T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
[ 10.286446][ T1] Call Trace:
[ 10.286986][ T1] <TASK>
[ 10.287455][ T1] dump_stack_lvl+0x3d/0x1f0
[ 10.288227][ T1] panic+0x6f5/0x7a0
[ 10.288985][ T1] ? __pfx_panic+0x10/0x10
[ 10.288985][ T1] ? show_trace_log_lvl+0x363/0x500
[ 10.288985][ T1] ? check_panic_on_warn+0x1f/0xb0
[ 10.288985][ T1] ? refcount_warn_saturate+0x1ed/0x210
[ 10.288985][ T1] check_panic_on_warn+0xab/0xb0
[ 10.288985][ T1] __warn+0xf1/0x3c0
[ 10.288985][ T1] ? __wake_up_klogd.part.0+0x99/0xf0
[ 10.288985][ T1] ? refcount_warn_saturate+0x1ed/0x210
[ 10.288985][ T1] report_bug+0x3c0/0x580
[ 10.288985][ T1] handle_bug+0x3d/0x70
[ 10.288985][ T1] exc_invalid_op+0x17/0x50
[ 10.288985][ T1] asm_exc_invalid_op+0x1a/0x20
[ 10.288985][ T1] RIP: 0010:refcount_warn_saturate+0x1ed/0x210
[ 10.298878][ T1] Code: 8b e8 17 42 d2 fc 90 0f 0b 90 90 e9 c3 fe ff ff e8 e8 d2 0f fd c6 05 bb 02 4d 0b 01 90 48 c7 c7 80 e3 8e 8b e8 f4 41 d2 fc 90 <0f> 0b 90 90 e9 a0 fe ff ff 48 89 ef e8 72 fb 6a fd e9 44 fe ff ff
[ 10.298878][ T1] RSP: 0000:ffffc900000673c0 EFLAGS: 00010286
[ 10.298878][ T1] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff814fe149
[ 10.298878][ T1] RDX: ffff888016ec8000 RSI: ffffffff814fe156 RDI: 0000000000000001
[ 10.298878][ T1] RBP: ffff88814168f58c R08: 0000000000000001 R09: 0000000000000000
[ 10.298878][ T1] R10: 0000000000000000 R11: 0000000000000001 R12: ffff88814168f58c
[ 10.298878][ T1] R13: 0000000000000000 R14: 0000000006ae00b9 R15: ffff88801687a588
[ 10.308799][ T1] ? __warn_printk+0x199/0x350
[ 10.308799][ T1] ? __warn_printk+0x1a6/0x350
[ 10.308799][ T1] __reset_page_owner+0x2ea/0x370
[ 10.308799][ T1] __free_pages_ok+0x5a9/0xbf0
[ 10.308799][ T1] ? __split_page_owner+0xdd/0x120
[ 10.308799][ T1] make_alloc_exact+0x165/0x260
[ 10.308799][ T1] vring_alloc_queue+0xc1/0x110
[ 10.308799][ T1] vring_alloc_queue_split+0x186/0x510
[ 10.308799][ T1] ? __pfx_vring_alloc_queue_split+0x10/0x10
[ 10.308799][ T1] ? kasan_save_stack+0x42/0x60
[ 10.308799][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.318898][ T1] vring_create_virtqueue_split+0xe8/0x280
[ 10.318898][ T1] ? __pfx_vp_notify+0x10/0x10
[ 10.318898][ T1] ? __pfx_vring_create_virtqueue_split+0x10/0x10
[ 10.318898][ T1] ? virtio_scsi_init+0x75/0x100
[ 10.318898][ T1] ? do_one_initcall+0x128/0x700
[ 10.318898][ T1] ? kernel_init_freeable+0x69d/0xca0
[ 10.318898][ T1] vring_create_virtqueue+0xd7/0x140
[ 10.318898][ T1] ? __pfx_vp_notify+0x10/0x10
[ 10.318898][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.318898][ T1] setup_vq+0x123/0x2f0
[ 10.318898][ T1] ? __pfx_vp_notify+0x10/0x10
[ 10.318898][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.328775][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.328775][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.328775][ T1] vp_setup_vq+0xb1/0x380
[ 10.328775][ T1] ? iowrite16+0x55/0x80
[ 10.328775][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 10.328775][ T1] vp_find_vqs_msix+0x661/0xe30
[ 10.328775][ T1] vp_find_vqs+0x58/0x560
[ 10.328775][ T1] virtscsi_init+0x459/0x9f0
[ 10.328775][ T1] ? __pfx_virtscsi_init+0x10/0x10
[ 10.328775][ T1] ? __pfx_default_calc_sets+0x10/0x10
[ 10.328775][ T1] ? ioread8+0x4e/0xa0
[ 10.328775][ T1] ? vp_get+0xf6/0x140
[ 10.328775][ T1] virtscsi_probe+0x3b2/0xdd0
[ 10.338889][ T1] ? __pfx_virtscsi_probe+0x10/0x10
[ 10.338889][ T1] ? trace_raw_output_sched_pi_setprio+0xad/0x150
[ 10.338889][ T1] ? vring_transport_features+0x49/0xb0
[ 10.338889][ T1] virtio_dev_probe+0x5ff/0x9b0
[ 10.338889][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 10.338889][ T1] really_probe+0x23e/0xa90
[ 10.338889][ T1] __driver_probe_device+0x1de/0x440
[ 10.338889][ T1] ? _raw_spin_unlock_irqrestore+0x52/0x80
[ 10.338889][ T1] driver_probe_device+0x4c/0x1b0
[ 10.338889][ T1] __driver_attach+0x283/0x580
[ 10.338889][ T1] ? __pfx___driver_attach+0x10/0x10
[ 10.338889][ T1] bus_for_each_dev+0x13c/0x1d0
[ 10.348774][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 10.348774][ T1] bus_add_driver+0x2ed/0x640
[ 10.348774][ T1] driver_register+0x15c/0x4b0
[ 10.348774][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 10.348774][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 10.348774][ T1] virtio_scsi_init+0x75/0x100
[ 10.348774][ T1] do_one_initcall+0x128/0x700
[ 10.348774][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 10.348774][ T1] ? trace_kmalloc+0x2d/0xe0
[ 10.348774][ T1] ? __kmalloc+0x218/0x440
[ 10.348774][ T1] kernel_init_freeable+0x69d/0xca0
[ 10.348774][ T1] ? __pfx_kernel_init+0x10/0x10
[ 10.348774][ T1] kernel_init+0x1c/0x2b0
[ 10.358850][ T1] ? __pfx_kernel_init+0x10/0x10
[ 10.358850][ T1] ret_from_fork+0x45/0x80
[ 10.358850][ T1] ? __pfx_kernel_init+0x10/0x10
[ 10.358850][ T1] ret_from_fork_asm+0x1a/0x30
[ 10.358850][ T1] </TASK>
[ 10.358850][ T1] Kernel Offset: disabled
[ 10.358850][ T1] Rebooting in 86400 seconds..


syzkaller build log:
go env (err=<nil>)
GO111MODULE='auto'
GOARCH='amd64'
GOBIN=''
GOCACHE='/syzkaller/.cache/go-build'
GOENV='/syzkaller/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/syzkaller/jobs-2/linux/gopath/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/syzkaller/jobs-2/linux/gopath'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.4'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/syzkaller/jobs-2/linux/gopath/src/github.com/google/syzkaller/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1980677323=/tmp/go-build -gno-record-gcc-switches'

git status (err=<nil>)
HEAD detached at db5b7ff0c
nothing to commit, working tree clean


tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:31: run command via tools/syz-env for best compatibility, see:
Makefile:32: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
go list -f '{{.Stale}}' ./sys/syz-sysgen | grep -q false || go install ./sys/syz-sysgen
make .descriptions
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:31: run command via tools/syz-env for best compatibility, see:
Makefile:32: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
bin/syz-sysgen
touch .descriptions
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=db5b7ff0c1508e1f6bc77ba4df578cabb88b9914 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240312-201727'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-fuzzer github.com/google/syzkaller/syz-fuzzer
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=db5b7ff0c1508e1f6bc77ba4df578cabb88b9914 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240312-201727'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-execprog github.com/google/syzkaller/tools/syz-execprog
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=db5b7ff0c1508e1f6bc77ba4df578cabb88b9914 -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240312-201727'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-stress github.com/google/syzkaller/tools/syz-stress
mkdir -p ./bin/linux_amd64
gcc -o ./bin/linux_amd64/syz-executor executor/executor.cc \
-m64 -O2 -pthread -Wall -Werror -Wparentheses -Wunused-const-variable -Wframe-larger-than=16384 -Wno-stringop-overflow -Wno-array-bounds -Wno-format-overflow -Wno-unused-but-set-variable -Wno-unused-command-line-argument -static-pie -fpermissive -w -DGOOS_linux=1 -DGOARCH_amd64=1 \
-DHOSTGOOS_linux=1 -DGIT_REVISION=\"db5b7ff0c1508e1f6bc77ba4df578cabb88b9914\"


Error text is too large and was truncated, full error text is at:
https://syzkaller.appspot.com/x/error.txt?x=14e14231180000


Tested on:

commit: 484193fe Merge tag 'powerpc-6.9-2' of git://git.kernel..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=8f186ceee5fcb0b8
dashboard link: https://syzkaller.appspot.com/bug?extid=d2a2c639d03ac200a4f1
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=1298a7b6180000