Re: [PATCH 1/1] arm64: dts: rockchip: disable analog audio for rock-5b

[Pratham Patel]

On Sunday, March 24th, 2024 at 17:44, Linux regression tracking (Thorsten Leemhuis) <regressions@xxxxxxxxxxxxx> wrote:

> 
> 
> On 24.03.24 12:43, Pratham Patel wrote:
> 
> > On Sunday, March 24th, 2024 at 16:51, Pratham Patel prathampatel@xxxxxxxxxxxxxx wrote:
> > 
> > > On Sunday, March 24th, 2024 at 16:15, Krzysztof Kozlowski krzysztof.kozlowski@xxxxxxxxxx wrote:
> > > 
> > > > > + /*
> > > > > + *analog-sound {
> > > > > + * compatible = "audio-graph-card";
> > > > > + * label = "rk3588-es8316";
> > > > 
> > > > Do not comment out code. Instead disable the nodes and provide
> > > > appropriate comment describing reason.
> > > 
> > > I tried changing the status from okay to disabled. That didn't work. The SBC
> > > still locked up during boot.
> > 
> > I think setting the status to fail should do the trick, instead of setting it to disabled.
> > Will try that and be back with a v2.
> 
> 
> Please CC the author of the change that broke things when submitting v2,
> which you afaics failed to do in this thread.
>  
> Ciao, Thorsten

Ack, will do.

 -- Pratham Patel