Re: [PATCH v2 1/3] wifi: ath: Convert sprintf/snprintf to sysfs_emit

From: Kalle Valo
Date: Mon Mar 25 2024 - 11:37:00 EST


Li Zhijian <lizhijian@xxxxxxxxxxx> wrote:

> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
>
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
>
> sprintf() will be converted as weel if they have.
>
> Generally, this patch is generated by
> make coccicheck M=<path/to/file> MODE=patch \
> COCCI=scripts/coccinelle/api/device_attr_show.cocci
>
> No functional change intended
>
> CC: Kalle Valo <kvalo@xxxxxxxxxx>
> CC: Jeff Johnson <jjohnson@xxxxxxxxxx>
> CC: linux-wireless@xxxxxxxxxxxxxxx
> CC: ath11k@xxxxxxxxxxxxxxxxxxx
> CC: ath10k@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

fa1a4f15bdca wifi: ath: Convert sprintf/snprintf to sysfs_emit

--
https://patchwork.kernel.org/project/linux-wireless/patch/20240315055211.1347548-1-lizhijian@xxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches