Re: [PATCH v1 1/3] hwmon: (pmbus/mp2975) Replace home made version of __assign_bit()

From: Guenter Roeck
Date: Mon Mar 25 2024 - 13:31:58 EST


On Mon, Mar 25, 2024 at 02:07:42PM +0200, Andy Shevchenko wrote:
> The newly introduced SWAP() macro is quite generic by naming, but
> moreover it's a repetition of the existing __assign_bit().
> With this applied, add a missing bits.h (via now required bitops.h).
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Not sure if I like __assign_bit() more than SWAP(), but at least it is
"standard". Applied.

Thanks,
Guenter