Re: [PATCH 5.10 000/237] 5.10.214-rc2 review

[Daniel Díaz]

Hello!

On 25/03/24 5:59 a. m., Sasha Levin wrote:
> This is the start of the stable review cycle for the 5.10.214 release.
> There are 237 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed Mar 27 11:59:18 AM UTC 2024.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>          https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-5.10.y&id2=v5.10.213
> or in the git tree and branch at:
>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> Thanks,
> Sasha

We see new warnings here too, on Ar64, Arm32, x86, i386, MIPS, PowerPC, RISC-V, System/390, SuperH, SPARC, ARC, on multiple combinations of toolchain and kernel configs.

-----8<-----
  /builds/linux/kernel/printk/printk.c:261:13: warning: 'panic_in_progress' defined but not used [-Wunused-function]
    261 | static bool panic_in_progress(void)
        |             ^~~~~~~~~~~~~~~~~
----->8-----

Bisection points to:

  commit 290ee7858f46d6f007150bcd90cee321cabb8545
  Author: Stephen Brennan <stephen.s.brennan@xxxxxxxxxx>
  Date:   Wed Feb 2 09:18:18 2022 -0800

      printk: Add panic_in_progress helper
      
      [ Upstream commit 77498617857f68496b360081dde1a492d40c28b2 ]

Reverting that commit makes the warning disappear.

Reproducer:

  tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-12 --kconfig allnoconfig

Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>


Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx