Re: [PATCH 5.4 000/180] 5.4.273-rc2 review

[Daniel Díaz]

Hello!

On 25/03/24 5:59 a. m., Sasha Levin wrote:
> This is the start of the stable review cycle for the 5.4.273 release.
> There are 180 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed Mar 27 11:59:07 AM UTC 2024.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>          https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-5.4.y&id2=v5.4.272
> or in the git tree and branch at:
>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> Thanks,
> Sasha

There is a new warning introduced here, on Arm (64- and 32-bits) with GCC 8, GCC 12, Clang 17:

-----8<-----
  /builds/linux/drivers/cpufreq/brcmstb-avs-cpufreq.c:462:23: warning: mixing declarations and code is a C99 extension [-Wdeclaration-after-statement]
    462 |         struct private_data *priv = policy->driver_data;
        |                              ^
  1 warning generated.
----->8-----

Bisection points to

  commit 8930178165fac14653ef502321efc3d5ca7c66c4
  Author: Anastasia Belova <abelova@xxxxxxxxxxxxx>
  Date:   Wed Jan 17 10:12:20 2024 +0300

      cpufreq: brcmstb-avs-cpufreq: add check for cpufreq_cpu_get's return value
      
      [ Upstream commit f661017e6d326ee187db24194cabb013d81bc2a6 ]


Reverting that commits makes the warning disappear.

Reproducer:

  tuxmake --runtime podman --target-arch arm64 --toolchain clang-17 --kconfig defconfig LLVM=1 LLVM_IAS=1

Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>


Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx