Re: [PATCH 1/3] dt-bindings: hwmon: Add maxim max31790 driver bindings

[Chanh Nguyen]

On 25/03/2024 15:32, Krzysztof Kozlowski wrote:
> On 22/03/2024 10:53, Chanh Nguyen wrote:
> > > > >
> > > >
> > > > Hi Krzysztof,
> > > > I have not yet understood your comment here. Please help give more
> > > > details for my missing! Thank Krzysztof!
> > >
> > > I expect many more properties of a fan controller. Resources (clocks,
> > > PWMs, supplies) and FAN specific properties.
> >
> > Hi Krzysztof,
> >
> > I'm creating a base binding document for the max31790 driver. I'm basing
> > it on the drivers/hwmon/max31790.c. Currently, the max31790.c driver has
>
> Binding should be based on device (e.g. its datasheet), not the driver.

Thank Krzysztof,
I'm reading the writing-bindings.rst and I got it for now. I'll make 
complete binding in patch v2.

I am very pleased to hear your comments.

> > not yet implemented other properties, such as clocks, fan-supply, pwms,
> > etc. So I just introduced the "compatible" and "reg" properties.
> >
> > In the near future, if any other properties are necessary, I think we
> > will implement them in drivers/hwmon/max31790.c then update this binding
> > document.
>
> Please instead read:
> Documentation/devicetree/bindings/writing-bindings.rst
>
> > I look at other binding documents, I also see something similar. They
> > just introduce the "compatible" and "reg" properties.
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml
>
> Maybe these devices are similar, maybe not. This should not be excuse to
> come with really incomplete binding.
>
> ...
>
> > I think "fan-controller" is a good node name. Do you think so?
>
> Yes.
>
> Best regards,
> Krzysztof