Re: [PATCH v2] scsi: libsas: Allocation SMP request is aligned to ARCH_DMA_MINALIGN

[Damien Le Moal]

On 3/26/24 22:32, John Garry wrote:
>> John,
>>
>> Unrelated to this patch, but I wonder if the GFP_KERNEL used here shouldn't be
>> GFP_NOIO... Is this ever called in the IO path or error recovery ?
>>
> 
> These should not be called in the IO path - as they are management 
> functions. But I am quite confident that they can be called in SCSI 
> error handling (for libsas).

So it sounds like GFP_NOIO would be a lot safer...

> 
> Thanks,
> John

-- 
Damien Le Moal
Western Digital Research