Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support

[Conor Dooley]

On Tue, Mar 26, 2024 at 02:54:56AM -0700, Tan Chun Hau wrote:
> Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> controller.

Your commit message should explain what makes this incompatible with
existing devices. That inforatiion does appear to be in the driver
patch, but should also be here. Otherwise,
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

> 
> Signed-off-by: Tan Chun Hau <chunhau.tan@xxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 363cf8bd150d..525f5f3932f5 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -21,6 +21,7 @@ properties:
>        - snps,axi-dma-1.01a
>        - intel,kmb-axi-dma
>        - starfive,jh7110-axi-dma
> +      - starfive,jh8100-axi-dma
>  
>    reg:
>      minItems: 1
> -- 
> 2.25.1
>

Attachment: signature.asc
Description: PGP signature