Re: [PATCH v2 1/1] usb: typec: ucsi: Check capabilities before cable and identity discovery

[Bjorn Andersson]

On Fri, Mar 15, 2024 at 05:18:35PM +0000, Jameson Thies wrote:
> Check the UCSI_CAP_GET_PD_MESSAGE bit before sending GET_PD_MESSAGE to
> discover partner and cable identity, check UCSI_CAP_CABLE_DETAILS before
> sending GET_CABLE_PROPERTY to discover the cable and check
> UCSI_CAP_ALT_MODE_DETAILS before registering the a cable plug. Additionally,
> move 8 bits from reserved_1 to features in the ucsi_capability struct. This
> makes the field 16 bits, still 8 short of the 24 bits allocated for it in
> UCSI v3.0, but it will not overflow because UCSI only defines 14 bits in
> bmOptionalFeatures.
> 
> Fixes: 38ca416597b0 ("usb: typec: ucsi: Register cables based on GET_CABLE_PROPERTY")
> Link: https://lore.kernel.org/linux-usb/44e8142f-d9b3-487b-83fe-39deadddb492@xxxxxxxxxx
> Suggested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> Signed-off-by: Jameson Thies <jthies@xxxxxxxxxx>

Thanks you, Jameson, this resolve the regression I ran into on
qcs6490-rb3gen2 as well.

Tested-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> # QCS6490 Rb3Gen2

Regards,
Bjorn