RE: [PATCH v4 0/7] crypto: starfive: Add support for JH8100

From: JiaJie Ho
Date: Tue Mar 26 2024 - 23:27:45 EST


> This patch series add driver support for StarFive JH8100 SoC crypto engine.
> Patch 1 adds compatible string and update irq descriptions for
> JH8100 device. Subsequent patches update current driver implementations to
> support both 7110 and 8100 variants.
>
> v3->v4:
> - Updated interrupts descriptions for jh8100-crypto compatible. (Rob)
> - Added patch 3 to skip unneeded key freeing for RSA module.
>
> v2->v3:
> - Use of device data instead of #ifdef CONFIG_ for different device
> variants.
> - Updated dt bindings compatible and interrupts descriptions.
> - Added patch 4 to support hardware quirks for dw-axi-dmac driver.
>
> v1->v2:
> - Resolved build warnings reported by kernel test robot
> https://lore.kernel.org/oe-kbuild-all/202312170614.24rtwf9x-
> lkp@xxxxxxxxx/
>
> Jia Jie Ho (7):
> dt-bindings: crypto: starfive: Add jh8100 support
> crypto: starfive: Update hash dma usage
> crypto: starfive: Skip unneeded key free
> crypto: starfive: Use dma for aes requests
> dmaengine: dw-axi-dmac: Support hardware quirks
> crypto: starfive: Add sm3 support for JH8100
> crypto: starfive: Add sm4 support for JH8100
>
> .../crypto/starfive,jh7110-crypto.yaml | 30 +-
> drivers/crypto/starfive/Kconfig | 30 +-
> drivers/crypto/starfive/Makefile | 5 +-
> drivers/crypto/starfive/jh7110-aes.c | 592 ++++++---
> drivers/crypto/starfive/jh7110-cryp.c | 77 +-
> drivers/crypto/starfive/jh7110-cryp.h | 114 +-
> drivers/crypto/starfive/jh7110-hash.c | 316 +++--
> drivers/crypto/starfive/jh7110-rsa.c | 3 +
> drivers/crypto/starfive/jh8100-sm3.c | 544 ++++++++
> drivers/crypto/starfive/jh8100-sm4.c | 1119 +++++++++++++++++
> .../dma/dw-axi-dmac/dw-axi-dmac-platform.c | 32 +-
> drivers/dma/dw-axi-dmac/dw-axi-dmac.h | 2 +
> include/linux/dma/dw_axi.h | 11 +
> 13 files changed, 2437 insertions(+), 438 deletions(-) create mode 100644
> drivers/crypto/starfive/jh8100-sm3.c
> create mode 100644 drivers/crypto/starfive/jh8100-sm4.c
> create mode 100644 include/linux/dma/dw_axi.h
>

Hi Herbert,
Could you please help review this patch series?

Thanks,
Jia Jie