Re: [PATCH net-next v2] tg3: Remove residual error handling in tg3_suspend

[Michael Chan]

On Tue, Mar 26, 2024 at 8:24 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Wed, 27 Mar 2024 08:14:30 +0530 Ratheesh Kannoth wrote:
> > > @@ -18090,7 +18090,6 @@ static int tg3_suspend(struct device *device)
> > >  {
> > Please address Michael Chan's comment to make this function return type to "void"
> > instead of "int"
>
> It's used as a callback in SIMPLE_DEV_PM_OPS(), how would that work?

It won't work.  I only requested to change tg3_power_down_prepare() to
void and it was done in v2:

https://lore.kernel.org/netdev/CACKFLinzJjqe0j4OFkcCV+FyH0JiUpnj3j2azZkGaC9jfvFXrQ@xxxxxxxxxxxxxx/

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature