Re: [EXTERNAL] [PATCH 3/9] qed: avoid truncating work queue length

[Arnd Bergmann]

On Wed, Mar 27, 2024, at 15:04, Subbaraya Sundeep Bhatta wrote:

>>-		snprintf(name, NAME_SIZE, "slowpath-%02x:%02x.%02x",
>>-			 cdev->pdev->bus->number,
>>-			 PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id);
>>+		hwfn->slowpath_wq = alloc_workqueue("slowpath-
>>%02x:%02x.%02x",
>>+					 0, 0, cdev->pdev->bus->number,
>>+					 PCI_SLOT(cdev->pdev->devfn),
>>+					 hwfn->abs_pf_id);
>
> Confused. This should be alloc_workqueue("slowpath-%02x:%02x.%02x",  
> cdev->pdev->bus->number, PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id, 
> 0, 0);
> Right?

I still think my version is the right one here, see the
prototype:

__printf(1, 4) struct workqueue_struct *
alloc_workqueue(const char *fmt, unsigned int flags, int max_active, ...);

so the first argument in the format, while the printf arguments
start after the flags and max_active arguments that are still both
set to zero.

      Arnd