Re: [PATCH 5.15 000/309] 5.15.153-rc2 review

[Guenter Roeck]

On 3/27/24 01:39, Harshit Mogalapalli wrote:
> Hi Sasha,
>
> On 25/03/24 17:29, Sasha Levin wrote:
> > This is the start of the stable review cycle for the 5.15.153 release.
> > There are 309 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed Mar 27 11:59:27 AM UTC 2024.
> > Anything received after that time might be too late.
>
> We still see this: Same as what Daniel reported at [1]
>
> drivers/cpufreq/brcmstb-avs-cpufreq.c: In function 'brcm_avs_cpufreq_get':
> drivers/cpufreq/brcmstb-avs-cpufreq.c:486:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
>    486 |         struct private_data *priv = policy->driver_data;
>        |         ^~~~~~
> cc1: all warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:289: drivers/cpufreq/brcmstb-avs-cpufreq.o] Error 1
> make[1]: *** [scripts/Makefile.build:552: drivers/cpufreq] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1907: drivers] Error 2
>
> [1] https://lore.kernel.org/stable/20240327015023.GC7502@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/T/#m15bff0fe96986ef780e848b4fff362bf8ea03f08
>
>
> Looks like, 5.15.153 is released, so we need to work on fixing this.

Same problem is seen in v5.10.214.

drivers/cpufreq/brcmstb-avs-cpufreq.c: In function 'brcm_avs_cpufreq_get':
drivers/cpufreq/brcmstb-avs-cpufreq.c:486:2: warning: ISO C90 forbids mixed declarations and code

Guenter