Re: [PATCH v6 07/14] drm/mediatek: Support alpha blending in display driver

[Shawn Sung (宋孝謙)]

Hi CK,

On Fri, 2024-03-22 at 09:37 +0000, CK Hu (胡俊光) wrote:
> > diff --git a/drivers/gpu/drm/mediatek/mtk_plane.c
> > b/drivers/gpu/drm/mediatek/mtk_plane.c
> > index 1723d4333f371..5bf757a3ef202 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_plane.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_plane.c
> > @@ -346,6 +346,17 @@ int mtk_plane_init(struct drm_device *dev,
> > struct drm_plane *plane,
> >  			DRM_INFO("Create rotation property failed\n");
> >  	}
> >  
> > +	err = drm_plane_create_alpha_property(plane);
> > +	if (err)
> > +		DRM_ERROR("failed to create property: alpha\n");
> > +
> > +	err = drm_plane_create_blend_mode_property(plane,
> > +						   BIT(DRM_MODE_BLEND_P
> > REMULTI) |
> > +						   BIT(DRM_MODE_BLEND_C
> > OVERAGE) |
> > +						   BIT(DRM_MODE_BLEND_P
> > IXEL_NONE));
> 
> After all sub driver support these function, then create blend
> property. So move this patch after all sub driver support these blend
> mode.
> 

Got it. Will rearrange the patches in the next version

Thanks,
Shawn