Re: [PATCH v2 2/6] arm64: dts: qcom: qcs6490-rb3gen2: Add DP output

[Bjorn Andersson]

On Thu, Mar 28, 2024 at 03:51:54AM +0200, Dmitry Baryshkov wrote:
> On Wed, 27 Mar 2024 at 04:04, Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> wrote:
> >
> > The RB3Gen2 board comes with a mini DP connector, describe this, enable
> > MDSS, DP controller and the PHY that drives this.
> >
> > Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 40 ++++++++++++++++++++++++++++
> >  1 file changed, 40 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > index 63ebe0774f1d..f90bf3518e98 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > @@ -39,6 +39,20 @@ chosen {
> >                 stdout-path = "serial0:115200n8";
> >         };
> >
> > +       dp-connector {
> > +               compatible = "dp-connector";
> > +               label = "DP";
> > +               type = "mini";
> > +
> > +               hpd-gpios = <&tlmm 60 GPIO_ACTIVE_HIGH>;
> 
> Is it the standard hpd gpio? If so, is there any reason for using it
> through dp-connector rather than as a native HPD signal?
> 

I added it because you asked for it. That said, I do like having it
clearly defined in the devicetree.

Regards,
Bjorn