Re: [PATCH v4 0/2] codingstyle: avoid unused parameters for a function-like macro
From: Barry Song
Date: Thu Mar 28 2024 - 00:22:34 EST
On Thu, Mar 28, 2024 at 3:21 PM Barry Song <21cnbao@xxxxxxxxx> wrote:
>
> From: Barry Song <v-songbaohua@xxxxxxxx>
>
> -v4:
> * fix Xining's email address, s/ma.xxn@xxxxxxxxxxx/mac.xxn@xxxxxxxxxxx/g
Hi Andrew,
Apologies for the oversight. Could you please apply these two patches to replace
the ones in the mm-nonmm-unstable branch? We need to correct Xining's email
address regardless.
> * fix some false positives of checkpatch.pl
> * downgrade from ERROR to WARN in checkpatch.pl
>
> Thanks for Joe's comments!
>
> -v3:
> https://lore.kernel.org/all/20240322084937.66018-1-21cnbao@xxxxxxxxx/
>
> A function-like macro could result in build warnings such as
> "unused variable." This patchset updates the guidance to
> recommend always using a static inline function instead
> and also provides checkpatch support for this new rule.
>
> Barry Song (1):
> Documentation: coding-style: ask function-like macros to evaluate
> parameters
>
> Xining Xu (1):
> scripts: checkpatch: check unused parameters for function-like macro
>
> Documentation/process/coding-style.rst | 16 ++++++++++++++
> scripts/checkpatch.pl | 30 ++++++++++++++++++++++++++
> 2 files changed, 46 insertions(+)
>
> --
> 2.34.1
>
Thanks
Barry