Re: [PATCH v4] thermal/drivers/tsens: Add suspend to RAM support for tsens

[Amit Kucheria]

On Wed, Mar 27, 2024 at 3:12 PM Priyansh Jain <quic_priyjain@xxxxxxxxxxx> wrote:
> On 3/26/2024 4:30 PM, Daniel Lezcano wrote:
> > On 26/03/2024 08:40, Priyansh Jain wrote:
> >> As part of suspend to RAM, tsens hardware will be turned off.
> >> While resume callback, re-initialize tsens hardware.
> >>
> >> Signed-off-by: Priyansh Jain <quic_priyjain@xxxxxxxxxxx>
> >> ---
> >> V3 -> V4: Make tsens_reinit function specific to tsens v2. Add
> >> NULL resume callback support for platform whose versions < ver_2_x
> >> in tsens ops.
> >> V2 -> V3: Remove suspend callback & interrupt enablement part from
> >> resume callback.
> >> V1 -> V2: Update commit text to explain the necessity of this patch
> >>
> >>   drivers/thermal/qcom/tsens-v0_1.c |  6 +++++
> >>   drivers/thermal/qcom/tsens-v1.c   |  3 +++
> >>   drivers/thermal/qcom/tsens-v2.c   |  1 +
> >>   drivers/thermal/qcom/tsens.c      | 37 +++++++++++++++++++++++++++++++
> >>   drivers/thermal/qcom/tsens.h      |  5 +++++
> >>   5 files changed, 52 insertions(+)
> >>
> >> diff --git a/drivers/thermal/qcom/tsens-v0_1.c
> >> b/drivers/thermal/qcom/tsens-v0_1.c
> >> index 32d2d3e33287..7ed85379247b 100644
> >> --- a/drivers/thermal/qcom/tsens-v0_1.c
> >> +++ b/drivers/thermal/qcom/tsens-v0_1.c
> >> @@ -329,6 +329,7 @@ static const struct tsens_ops ops_8226 = {
> >>       .init        = init_8226,
> >>       .calibrate    = tsens_calibrate_common,
> >>       .get_temp    = get_temp_common,
> >> +    .resume        = NULL,
> >
> > As a static variable it is already set to NULL. Why do you need to
> > explicitly set them everywhere ?
> >
> It was asked in last version to explicitly add (.resume = NULL). So
> added this for all the tsens platforms for which resume callback is not
> validated.

Daniel's right, you can lose this bit now that your reinit function
will only work for 2.x.