Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

From: Alexandre Mergnat
Date: Thu Mar 28 2024 - 06:10:07 EST


Hi Angelo

On 26/02/2024 15:54, AngeloGioacchino Del Regno wrote:
Il 26/02/24 15:01, Alexandre Mergnat ha scritto:
This serie aim to add the following audio support for the Genio 350-evk:
- Playback
   - 2ch Headset Jack (Earphone)
   - 1ch Line-out Jack (Speaker)
   - 8ch HDMI Tx
- Capture
   - 1ch DMIC (On-board Digital Microphone)
   - 1ch AMIC (On-board Analogic Microphone)
   - 1ch Headset Jack (External Analogic Microphone)

Of course, HDMI playback need the MT8365 display patches [1] and a DTS
change documented in "mediatek,mt8365-mt6357.yaml".

[1]: https://lore.kernel.org/all/20231023-display-support-v1-0-5c860ed5c33b@xxxxxxxxxxxx/

Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>

Actually, I am cooking a series (I'm finishing the testing....) that brings quite
a bit of cleanups in MTK ASoC, including the commonization of the machine driver
probe, with the dai-link DT nodes, and which also modernizes most of the existing
drivers to use that instead.

If you wait for a day or two, your mt8365-mt6357.c driver's probe function can be
shrunk to ~3 lines or something like that.. very easily :-)

Just to inform you. I'm aware of your serie. Currently, I've fixed my patches according to the comments. The next step will be to rebase my serie over yours and do the changes to be aligned with your new implementation.

I've planned to review your serie during my last task, but it seems already approved and already (partially) merged into linux-next, sorry.


--
Regards,
Alexandre