Re: [PATCH] drm: DRM_WERROR should depend on DRM

From: Jani Nikula
Date: Thu Mar 28 2024 - 07:11:21 EST


On Tue, 26 Mar 2024, Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
> On Tue, 26 Mar 2024, Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote:
>> There is no point in asking the user about enforcing the DRM compiler
>> warning policy when configuring a kernel without DRM support.
>>
>> Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> D'oh! My bad.
>
> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

And pushed to drm-misc-next. Thanks for the patch!

BR,
Jani.

>
>> ---
>> drivers/gpu/drm/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>> index f2bcf5504aa77679..2e1b23ccf30423a9 100644
>> --- a/drivers/gpu/drm/Kconfig
>> +++ b/drivers/gpu/drm/Kconfig
>> @@ -423,7 +423,7 @@ config DRM_PRIVACY_SCREEN
>>
>> config DRM_WERROR
>> bool "Compile the drm subsystem with warnings as errors"
>> - depends on EXPERT
>> + depends on DRM && EXPERT
>> default n
>> help
>> A kernel build should not cause any compiler warnings, and this

--
Jani Nikula, Intel