Re: [PATCH v5 1/1] dt-bindings: net: dwmac: Document STM32 property st,ext-phyclk

[Christophe ROULLIER]

On 3/28/24 15:19, Marek Vasut wrote:
> On 3/28/24 3:08 PM, Christophe Roullier wrote:
>
> [...]
>
> > | RMII    |    -   |     eth-ck    | eth-ck        |       n/a        |
> > |         |        | st,ext-phyclk | st,eth-ref-clk-sel 
> > |                  |
> > |         |        |               | or st,ext-phyclk 
> > |                  |
> >
> > --------------------------------------------------------------------------- 
> >
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Signed-off-by: Christophe Roullier <christophe.roullier@xxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml 
> > b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
> > index fc8c96b08d7dc..b35eae80ed6ac 100644
> > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
> > @@ -82,6 +82,13 @@ properties:
> >         Should be phandle/offset pair. The phandle to the syscon node 
> > which
> >         encompases the glue register, and the offset of the control 
> > register
> >   +st,ext-phyclk:
>
> Don't you need two spaces in front of the 'st,' here ?
Sorry, that's right.
> > +    description:
> > +      set this property in RMII mode when you have PHY without 
> > crystal 50MHz and want to
> > +      select RCC clock instead of ETH_REF_CLK. OR in RGMII mode when 
> > you want to select
> > +      RCC clock instead of ETH_CLK125.
> > +    type: boolean
> > +
>
> With that fixed:
>
> Reviewed-by: Marek Vasut <marex@xxxxxxx>