Re: [PATCH 0/2] Fix selftests/mm build without requiring "make headers"

From: John Hubbard
Date: Thu Mar 28 2024 - 13:30:26 EST


On 3/28/24 2:02 AM, Muhammad Usama Anjum wrote:
On 3/28/24 8:34 AM, John Hubbard wrote:
Hi,

As mentioned in each patch, this implements the solution that we discussed in
December 2023, in [1]. This turned out to be very clean and easy. It should also
be quite easy to maintain.
There is another way. The headers should be built automatically by make
dependency. The topmost make file always builds headers before building
kselftest i.e., make kselftest


I think we talked through this already: Peter Z. pointed out the problems
with requiring this kind of prerequisite. And it really it overkill. The
approach here is simple, easy to maintain, and avoids breaking the various
unusual build setups that people have.

I'll shut up now and let others weigh in, though. :)


thanks,
--
John Hubbard
NVIDIA