Re: [PATCH 02/19] Input: atlas: - drop owner assignment

From: Dmitry Torokhov
Date: Thu Mar 28 2024 - 13:55:27 EST


On Wed, Mar 27, 2024 at 08:43:49AM +0100, Krzysztof Kozlowski wrote:
> ACPI bus core already sets the .owner, so driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

But please fix the stray colon in the subject.

>
> ---
>
> Depends on the first patch.
> ---
> drivers/input/misc/atlas_btns.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/atlas_btns.c b/drivers/input/misc/atlas_btns.c
> index 3c9bbd04e143..5b9be2957746 100644
> --- a/drivers/input/misc/atlas_btns.c
> +++ b/drivers/input/misc/atlas_btns.c
> @@ -127,7 +127,6 @@ MODULE_DEVICE_TABLE(acpi, atlas_device_ids);
> static struct acpi_driver atlas_acpi_driver = {
> .name = ACPI_ATLAS_NAME,
> .class = ACPI_ATLAS_CLASS,
> - .owner = THIS_MODULE,
> .ids = atlas_device_ids,
> .ops = {
> .add = atlas_acpi_button_add,
>
> --
> 2.34.1
>

--
Dmitry