Re: [PATCH][next] staging: vt6655: remove redundant assignment to variable byData

[Philipp Hortmann]

On 3/28/24 12:15, Colin Ian King wrote:
> Variable byData is being assigned a value that is never read, it is
> being re-assigned later on. The assignment is redundant and can be
> removed.
>
> Cleans up clang scan build warning:
> drivers/staging/vt6655/srom.c:67:2: warning: Value stored to 'byData'
> is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
>   drivers/staging/vt6655/srom.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> index 1b89d401a7eb..e80556509c58 100644
> --- a/drivers/staging/vt6655/srom.c
> +++ b/drivers/staging/vt6655/srom.c
> @@ -64,7 +64,6 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
>   	unsigned char byData;
>   	unsigned char byOrg;
>   
> -	byData = 0xFF;
>   	byOrg = ioread8(iobase + MAC_REG_I2MCFG);
>   	/* turn off hardware retry for getting NACK */
>   	iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);


Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>