Re: [PATCH] wifi: mac80222: Fix ieee80211_i.h kernel-doc issues
From: Jeff Johnson
Date: Thu Mar 28 2024 - 19:08:18 EST
On 3/28/2024 3:16 PM, Randy Dunlap wrote:
> Hi,
>
> On 3/28/24 14:08, Jeff Johnson wrote:
>> kernel-doc flagged the following issues:
>>
>> net/mac80211/ieee80211_i.h:146: warning: expecting prototype for enum ieee80211_corrupt_data_flags. Prototype was for enum ieee80211_bss_corrupt_data_flags instead
>> net/mac80211/ieee80211_i.h:163: warning: expecting prototype for enum ieee80211_valid_data_flags. Prototype was for enum ieee80211_bss_valid_data_flags instead
>>
>> Correct the documentation to match the code.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
>
> These seem to be corrected in linux-next already.
Looks like I fixed these two earlier -- not sure why they haven't reached
wireless-next yet which was the code I was looking at today.
I've flagged as N/A in patchwork
> However, I do still see this one:
>
> ieee80211_i.h:689: warning: missing initial short description on line:
> * struct mesh_table
Ah, I haven't been adding [-Wshort-desc[ription]] (or some of the other -W
switches)
Yay, I can find even more issues.
I'll fix this one