Re: [PATCH v5 2/2] ASoC: nau8325: new driver

[WTLI]

Mark Brown 於 3/28/2024 11:22 PM 寫道:
> On Wed, Mar 27, 2024 at 03:57:55PM +0800, Seven Lee wrote:
>
> > +static const char * const nau8325_dac_oversampl[] = {
> > +    "64", "256", "128", "", "32" };
> > +
> > +static const struct soc_enum nau8325_dac_oversampl_enum =
> > +    SOC_ENUM_SINGLE(NAU8325_R29_DAC_CTRL1, NAU8325_DAC_OVERSAMPLE_SFT,
> > +                    ARRAY_SIZE(nau8325_dac_oversampl),
> > +                    nau8325_dac_oversampl);
> This should really be a SOC_VALUE_ENUM so you can just hide the fourth
> value rather than having the empty (presumably invalid) option.  Please
> send an incremental patch doing this.

okay, thanks for reminding.

________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.