Re: [PATCH v6 17/23] dt-bindings: crypto: meson: remove clk and second interrupt line for GXL

[Conor Dooley]

On Fri, Mar 29, 2024 at 11:14:29AM +0000, Alexey Romanov wrote:
> Hi Conor,
> 
> On Tue, Mar 26, 2024 at 06:09:37PM +0000, Conor Dooley wrote:
> > On Tue, Mar 26, 2024 at 06:32:13PM +0300, Alexey Romanov wrote:
> > > GXL crypto IP uses DMA engine, which doesn't require clk input
> > > and second interrupt line.
> > > 
> > > Fixes: c4a0457eb858 ("ARM64: dts: amlogic: adds crypto hardware node")
> > 
> > How does this fix a commit that only modifies a dts? The commit cited
> > here should be a dt-bindings commit.
> 
> Yep, my bad. Will fix it in next series.
> 
> > 
> > However, your commit message says "require" but you do more than remove
> > these as required, you remove them entirely. What am I missing?
> 
> Crypto HW isn't connected to clk / 2nd interrput line, so we must remove
> them from dt. I will reformulate commit message.

Yeah, please do. Be clear about the hardware not actually having these
things. And hopefully Corentin can chime in as to why he thought it did.

Attachment: signature.asc
Description: PGP signature