Re: [PATCH 10/10] sparc64: Fix prototype warnings for vdso

[Arnd Bergmann]

On Sat, Mar 30, 2024, at 10:57, Sam Ravnborg via B4 Relay wrote:
> From: Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> Fix the following warnings:
> arch/sparc/vdso/vclock_gettime.c:254:1: error: no previous prototype 
> for ‘__vdso_clock_gettime’
> arch/sparc/vdso/vclock_gettime.c:282:1: error: no previous prototype 
> for ‘__vdso_clock_gettime_stick’
> arch/sparc/vdso/vclock_gettime.c:307:1: error: no previous prototype 
> for ‘__vdso_gettimeofday’
> arch/sparc/vdso/vclock_gettime.c:343:1: error: no previous prototype 
> for ‘__vdso_gettimeofday_stick’
> arch/sparc/vdso/vdso32/../vclock_gettime.c:254:1: error: no previous 
> prototype for ‘__vdso_clock_gettime’
> arch/sparc/vdso/vdso32/../vclock_gettime.c:282:1: error: no previous 
> prototype for ‘__vdso_clock_gettime_stick’
> arch/sparc/vdso/vdso32/../vclock_gettime.c:307:1: error: no previous 
> prototype for ‘__vdso_gettimeofday’
> arch/sparc/vdso/vdso32/../vclock_gettime.c:343:1: error: no previous 
> prototype for ‘__vdso_gettimeofday_stick’
>
> The warnings were fixed by adding the proper prototypes to asm/vdso.h.
> The better fix would be to convert sparc to be y2038 compliant so the
> generic variant of vdso.h could be used.

I would prefer leaving the warning here until it is fixed
properly, or possibly removing the broken compat vdso
support. The other patches look fine though.

      Arnd