Re: [PATCH] HID: i2c-hid: Revert to await reset ACK before reading report descriptor

From: Kenny Levinsen
Date: Sun Mar 31 2024 - 14:23:19 EST


On 3/31/24 3:23 PM, Kenny Levinsen wrote:
diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 2df1ab3c31cc..be5d661dde41 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -737,7 +737,9 @@ static int i2c_hid_parse(struct hid_device *hid)
ret = i2c_hid_start_hwreset(ihid);
if (ret)
msleep(1000);
+ ret = i2c_hid_finish_hwreset(ihid);

Ah, missed the check to only call i2c_hid_finish_hwreset if i2c_hid_start_hwreset succeeded, v2 incoming.