Re: [PATCH v4.19-v5.4] vt: fix memory overlapping when deleting chars in the buffer

From: Greg KH
Date: Mon Apr 01 2024 - 05:37:48 EST


On Mon, Apr 01, 2024 at 02:51:55PM +0530, Ajay Kaher wrote:
> On Sat, Mar 30, 2024 at 2:37 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Fri, Mar 29, 2024 at 12:12:08PM -0700, Kuntal Nayak wrote:
> > > From: Yangxi Xiang <xyangxi5@xxxxxxxxx>
> > >
> > > [ upstream commit 39cdb68c64d8 ]
> >
> > Please use the full git id in the future, it makes it easier and our
> > tools want it that way so that we can tell the difference between a
> > "Fixes:" tag and an actual backport. I'll go queue this up now, thanks!
> >
>
> Thanks Greg for accepting the patch.
>
> ./scripts/checkpatch.pl confuse developers, as it gives error/warning
> if we use full git id.

No need to run checkpatch on backports, as the changelog text should not
be an issue.

> Example:
> ERROR: Please use git commit description style 'commit <12+ chars of
> sha1> ("<title line>")' - ie: 'commit e26d3009efda ("netfilter:
> nf_tables: disallow timeout for anonymous sets")'
> #6:
> commit e26d3009efda338f19016df4175f354a9bd0a4ab upstream.
>
> Or shall we have something ./scripts/checkpatchstable.pl or
> ./scripts/checkpatch.pl stable (pass argument)?

Nah, it's never come up before now, I don't think people actually run
it, and I know I've never done so or even noticed, so all is fine.

thanks,

greg k-h