Re: [PATCH net-next v4 1/3] net: ethernet: ti: am65-cpts: Enable PTP RX HW timestamp using CPTS FIFO

From: Chintan Vankar
Date: Mon Apr 01 2024 - 05:43:04 EST




On 30/03/24 03:31, Jakub Kicinski wrote:
On Wed, 27 Mar 2024 11:12:32 +0530 Chintan Vankar wrote:
CPTS module supports capturing timestamp for every packet it receives,
add a new function named "am65_cpts_find_rx_ts()" to get the timestamp
of received packets from CPTS FIFO.

Add another function named "am65_cpts_rx_timestamp()" which internally
calls "am65_cpts_find_rx_ts()" function and timestamps the received
PTP packets.

Maybe i'm unusually tied today but reading this patch without reading
the next one makes no sense. I mean, you say:

CPTS module supports capturing timestamp for every packet it
receives...

How is that relevant here.

Yes, I got your point it is not relevant here, I will update commit
message in next version.


When you post v5 please make sure to include a cover letter, explaining
the overall goal and impact of the series.

+ list_del_init(&event->list);
+ list_add(&event->list, &cpts->pool);

list_move() ?

Thanks for suggestion, I will update these function calls.