Re: [PATCH v5 07/10] drm/ci: meson: Add job to test panfrost GPU driver

[Helen Koike]

On 01/04/2024 03:12, Vignesh Raman wrote:
> For amlogic meson SOC the GPU driver is panfrost. So add
> support in drm-ci to test panfrost driver for amlogic meson
> SOC and update xfails. Skip KMS tests for panfrost driver since
> it is not a not a KMS driver and skip driver-specific tests.
>
> Signed-off-by: Vignesh Raman <vignesh.raman@xxxxxxxxxxxxx>

Nit: Maybe squash this with previous commit.

With or without this change:

Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx>

Thanks
Helen

> ---
>
> v2:
>    - Add panfrost GPU jobs for amlogic meson SOC with new xfails.
>
> v3:
>    - Skip KMS tests for panfrost driver since it is not a not a KMS
>      driver and update xfails. Add the job name in GPU_VERSION and use
>      it for xfail file names instead of using DRIVER_NAME.
>
> v4:
>    - Remove the gpu suffix in job and rename xfails accordingly.
>
> v5:
>    - Use panfrost-gpu job and skip driver-specific tests.
>
> ---
>   drivers/gpu/drm/ci/test.yml                       | 5 +++++
>   drivers/gpu/drm/ci/xfails/panfrost-g12b-fails.txt | 1 +
>   drivers/gpu/drm/ci/xfails/panfrost-g12b-skips.txt | 8 ++++++++
>   3 files changed, 14 insertions(+)
>   create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-g12b-fails.txt
>   create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-g12b-skips.txt
>
> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
> index 505733069995..d1d42ff7df2d 100644
> --- a/drivers/gpu/drm/ci/test.yml
> +++ b/drivers/gpu/drm/ci/test.yml
> @@ -381,6 +381,11 @@ meson:g12b:
>       - .g12b
>       - .meson-display
>   
> +panfrost:g12b:
> +  extends:
> +    - .g12b
> +    - .panfrost-gpu
> +
>   virtio_gpu:none:
>     stage: virtio-gpu
>     variables:
> diff --git a/drivers/gpu/drm/ci/xfails/panfrost-g12b-fails.txt b/drivers/gpu/drm/ci/xfails/panfrost-g12b-fails.txt
> new file mode 100644
> index 000000000000..6f5e760d5ec0
> --- /dev/null
> +++ b/drivers/gpu/drm/ci/xfails/panfrost-g12b-fails.txt
> @@ -0,0 +1 @@
> +panfrost_prime@gem-prime-import,Fail
> diff --git a/drivers/gpu/drm/ci/xfails/panfrost-g12b-skips.txt b/drivers/gpu/drm/ci/xfails/panfrost-g12b-skips.txt
> new file mode 100644
> index 000000000000..41a846a59644
> --- /dev/null
> +++ b/drivers/gpu/drm/ci/xfails/panfrost-g12b-skips.txt
> @@ -0,0 +1,8 @@
> +# Panfrost is not a KMS driver, so skip the KMS tests
> +kms_.*
> +
> +# Skip driver specific tests
> +msm_.*
> +^amdgpu.*
> +v3d_.*
> +vc4_.*