Re: [PATCH v19 038/130] KVM: TDX: create/destroy VM structure

[Isaku Yamahata]

On Fri, Mar 29, 2024 at 02:22:12PM +0800,
Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx> wrote:

> 
> 
> On 3/21/2024 10:17 PM, Isaku Yamahata wrote:
> > On Wed, Mar 20, 2024 at 01:12:01PM +0800,
> > Chao Gao <chao.gao@xxxxxxxxx> wrote:
> > 
> > > > config KVM_SW_PROTECTED_VM
> > > > 	bool "Enable support for KVM software-protected VMs"
> > > > -	depends on EXPERT
> 
> This change is not needed, right?
> Since you intended to use KVM_GENERIC_PRIVATE_MEM, not KVM_SW_PROTECTED_VM.

Right. The fix will be something as follows.

diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index f2bc78ceaa9a..e912b128bddb 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -77,6 +77,7 @@ config KVM_WERROR
 
 config KVM_SW_PROTECTED_VM
        bool "Enable support for KVM software-protected VMs"
+       depends on EXPERT
        depends on KVM && X86_64
        select KVM_GENERIC_PRIVATE_MEM
        help
@@ -90,7 +91,7 @@ config KVM_SW_PROTECTED_VM
 config KVM_INTEL
        tristate "KVM for Intel (and compatible) processors support"
        depends on KVM && IA32_FEAT_CTL
-       select KVM_SW_PROTECTED_VM if INTEL_TDX_HOST
+       select KVM_GENERIC_PRIVATE_MEM if INTEL_TDX_HOST
        select KVM_GENERIC_MEMORY_ATTRIBUTES if INTEL_TDX_HOST
        help
          Provides support for KVM on processors equipped with Intel's VT
-- 
2.43.2
-- 
Isaku Yamahata <isaku.yamahata@xxxxxxxxx>