Re: [PATCH] scsi: sd: unregister device if device_add_disk() failed in sd_probe()

From: Damien Le Moal
Date: Mon Apr 01 2024 - 20:17:53 EST


On 4/2/24 02:51, Bart Van Assche wrote:
> On 3/31/24 18:31, Yu Kuai wrote:
>> I was shocked that this patch is still there. This patch is easy and
>> straightforward.
>>
>> LGTM
>> Reviewed-by: Yu Kuai <yukuai3@xxxxxxxxxx>
>>
>> BTW, Nan, it will be better if you have a reporducer for this.
> Agreed that a reproducer would help. No information is present in the
> patch description about how this issue was detected nor about how it was
> tested. That probably would have encouraged reviewers.

May be submit the reproducer as a blktest case while at it ?

>
> Bart.
>

--
Damien Le Moal
Western Digital Research