Re: [PATCH] stackdepot: Rename pool_index to pool_index_plus_1

[Marco Elver]

On Tue, 2 Apr 2024 at 09:04, Alexander Potapenko <glider@xxxxxxxxxx> wrote:
>
> On Tue, Apr 2, 2024 at 8:54 AM Vlastimil Babka <vbabka@xxxxxxx> wrote:
> >
> > On 4/2/24 2:14 AM, Peter Collingbourne wrote:
> > > Commit 3ee34eabac2a ("lib/stackdepot: fix first entry having a
> > > 0-handle") changed the meaning of the pool_index field to mean "the
> > > pool index plus 1". This made the code accessing this field less
> > > self-documenting, as well as causing debuggers such as drgn to not
> > > be able to easily remain compatible with both old and new kernels,
> > > because they typically do that by testing for presence of the new
> > > field. Because stackdepot is a debugging tool, we should make sure
> > > that it is debugger friendly. Therefore, give the field a different
> > > name to improve readability as well as enabling debugger backwards
> > > compatibility.
> > >
> > > Signed-off-by: Peter Collingbourne <pcc@xxxxxxxxxx>
> > > Link: https://linux-review.googlesource.com/id/Ib3e70c36c1d230dd0a118dc22649b33e768b9f88
> >
> > Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> Reviewed-by: Alexander Potapenko <glider@xxxxxxxxxx>

Acked-by: Marco Elver <elver@xxxxxxxxxx>