Re: [PATCH] mtd: spi-nor: macronix: Add support for mx25um51245g

[Michael Walle]

[+ linux-mtd ]

Hi,

On Thu Mar 28, 2024 at 12:52 PM CET, Witold Sadowski wrote:
> The Macronix mx25um51245g is a 1.8V, 512Mbit (64MB) device that
> supports x1, or x8 operation.
>
> Tested on Marvell Octeon SoC hardware with a Cadence xSPI controller.
>
> Signed-off-by: Witold Sadowski <wsadowski@xxxxxxxxxxx>

You haven't CC'ed the correct list, therefore it's unlikely this
will get a proper review/getting merged at all.

As Krzysztof already pointed out on another series of yours, please
read submitting-patches.rst.

For nor flash related submissions please also read:
https://docs.kernel.org/driver-api/mtd/spi-nor.html

> ---
>  drivers/mtd/spi-nor/macronix.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index ea6be95e75a5..f5fbdb7912e0 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -182,6 +182,12 @@ static const struct flash_info macronix_nor_parts[] = {
>  		.name = "mx25l3255e",
>  		.size = SZ_4M,
>  		.no_sfdp_flags = SECT_4K,
> +	}, {
> +                .id = SNOR_ID(0xc2, 0x80, 0x3a),

Wrong indentation?. Please use checkpatch.pl.

> +                .name = "mx25um51245g",

drop the name.

> +                .size = SZ_64M,

This is also autodetected. Drop it.

> +                .no_sfdp_flags = SECT_4K,

No "no_sfdp_flags" for SFDP capable flashes. Drop it.


> +                .fixup_flags = SPI_NOR_4B_OPCODES,

Doesn't the flash have proper a 4BAIT table?

-michael

Attachment: signature.asc
Description: PGP signature