Re: [PATCH 19/26] netfs: New writeback implementation

From: David Howells
Date: Tue Apr 02 2024 - 04:46:52 EST


David Howells <dhowells@xxxxxxxxxx> wrote:

> +struct netfs_io_request *new_netfs_begin_writethrough(struct kiocb *iocb, size_t len)
> +{
> + struct netfs_io_request *wreq = NULL;
> + struct netfs_inode *ictx = netfs_inode(file_inode(iocb->ki_filp));
> +
> + mutex_lock(&ictx->wb_lock);
> +
> + wreq = netfs_create_write_req(iocb->ki_filp->f_mapping, iocb->ki_filp,
> + iocb->ki_pos, NETFS_WRITETHROUGH);
> + if (IS_ERR(wreq))
> + mutex_unlock(&ictx->wb_lock);

This needs a "return wreq;" adding and appropriate braces. Thanks to those
who pointed it out.

David