Re: [PATCH v2 4/9] platform/x86: asus-wmi: support toggling POST sound

[Ilpo Järvinen]

On Tue, 2 Apr 2024, Luke D. Jones wrote:

> Add support for toggling the BIOS POST sound on some ASUS laptops.
> 
> Signed-off-by: Luke D. Jones <luke@xxxxxxxxxx>
> ---
>  .../ABI/testing/sysfs-platform-asus-wmi       |  9 ++++
>  drivers/platform/x86/asus-wmi.c               | 51 +++++++++++++++++++
>  include/linux/platform_data/x86/asus-wmi.h    |  3 ++
>  3 files changed, 63 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> index ef1ac1a20a71..41b92e53e88a 100644
> --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> @@ -194,3 +194,12 @@ Contact:	"Luke Jones" <luke@xxxxxxxxxx>
>  Description:
>  		Set the target temperature limit of the Nvidia dGPU:
>  			* min=75, max=87
> +
> +What:		/sys/devices/platform/<platform>/boot_sound
> +Date:		Apr 2024
> +KernelVersion:	6.10
> +Contact:	"Luke Jones" <luke@xxxxxxxxxx>
> +Description:
> +		Set if the BIOS POST sound is played on boot.
> +			* 0 - False,
> +			* 1 - True
> \ No newline at end of file

Add the last newline please.

After fixing that, please add:

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>


-- 
 i.