RE: [EXT] Re: [PATCH v10 03/11] arm64: dts: imx8ulp-evk: enable usb nodes and add ptn5150 nodes

[Xu Yang]

> 
> On Thu, Mar 21, 2024 at 04:14:31PM +0800, Xu Yang wrote:
> > Enable 2 USB nodes and add 2 PTN5150 nodes on i.MX8ULP evk board.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx>
> >
> > ---
> > Changes in v2:
> >  - fix format as suggusted by Fabio
> >  - add PTN5150 nodes
> > Changes in v3:
> >  - no changes
> > Changes in v4:
> >  - no changes
> > Changes in v5:
> >  - no changes
> > Changes in v6:
> >  - no changes
> > Changes in v7:
> >  - no changes
> > Changes in v8:
> >  - no changes
> > Changes in v9:
> >  - no changes
> > Changes in v10:
> >  - no changes
> > ---
> >  arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 84 +++++++++++++++++++
> >  1 file changed, 84 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> > index 69dd8e31027c..bf418af31039 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> > @@ -133,6 +133,64 @@ pcal6408: gpio@21 {
> >               gpio-controller;
> >               #gpio-cells = <2>;
> >       };
> > +
> > +     ptn5150_1: typec@1d {
> 
> Could you sort devices in unit-address?

Okay.

> 
> > +             compatible = "nxp,ptn5150";
> > +             reg = <0x1d>;
> > +             int-gpios = <&gpiof 3 IRQ_TYPE_EDGE_FALLING>;
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_typec1>;
> > +             status = "disabled";
> > +     };
> > +
> > +     ptn5150_2: typec@3d {
> > +             compatible = "nxp,ptn5150";
> > +             reg = <0x3d>;
> > +             int-gpios = <&gpiof 5 IRQ_TYPE_EDGE_FALLING>;
> > +                     pinctrl-names = "default";
> 
> Broken indent?

Yes, will fix it.

Thanks,
Xu Yang

> 
> Shawn
> 
> > +             pinctrl-0 = <&pinctrl_typec2>;
> > +             status = "disabled";
> > +     };
> > +};
> > +
> > +&usbotg1 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_usb1>;
> > +     dr_mode = "otg";
> > +     hnp-disable;
> > +     srp-disable;
> > +     adp-disable;
> > +     over-current-active-low;
> > +     status = "okay";
> > +};
> > +
> > +&usbphy1 {
> > +     fsl,tx-d-cal = <110>;
> > +     status = "okay";
> > +};
> > +
> > +&usbmisc1 {
> > +     status = "okay";
> > +};
> > +
> > +&usbotg2 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_usb2>;
> > +     dr_mode = "otg";
> > +     hnp-disable;
> > +     srp-disable;
> > +     adp-disable;
> > +     over-current-active-low;
> > +     status = "okay";
> > +};
> > +
> > +&usbphy2 {
> > +     fsl,tx-d-cal = <110>;
> > +     status = "okay";
> > +};
> > +
> > +&usbmisc2 {
> > +     status = "okay";
> >  };
> >
> >  &usdhc0 {
> > @@ -224,6 +282,32 @@ MX8ULP_PAD_PTE13__LPI2C7_SDA     0x20
> >               >;
> >       };
> >
> > +     pinctrl_typec1: typec1grp {
> > +             fsl,pins = <
> > +                     MX8ULP_PAD_PTF3__PTF3           0x3
> > +             >;
> > +     };
> > +
> > +     pinctrl_typec2: typec2grp {
> > +             fsl,pins = <
> > +                     MX8ULP_PAD_PTF5__PTF5           0x3
> > +             >;
> > +     };
> > +
> > +     pinctrl_usb1: usb1grp {
> > +             fsl,pins = <
> > +                     MX8ULP_PAD_PTF2__USB0_ID        0x10003
> > +                     MX8ULP_PAD_PTF4__USB0_OC        0x10003
> > +             >;
> > +     };
> > +
> > +     pinctrl_usb2: usb2grp {
> > +             fsl,pins = <
> > +                     MX8ULP_PAD_PTD23__USB1_ID       0x10003
> > +                     MX8ULP_PAD_PTF6__USB1_OC        0x10003
> > +             >;
> > +     };
> > +
> >       pinctrl_usdhc0: usdhc0grp {
> >               fsl,pins = <
> >                       MX8ULP_PAD_PTD1__SDHC0_CMD      0x3
> > --
> > 2.34.1
> >