Re: [PATCH v2] HID: i2c-hid: Revert to await reset ACK before reading report descriptor
From: Hans de Goede
Date: Tue Apr 02 2024 - 07:43:52 EST
Hi,
On 4/2/24 1:30 PM, Kenny Levinsen wrote:
> On 4/2/24 1:06 PM, Hans de Goede wrote:
>> One small remark comment below. In the hope of getting this merged
>> soon I'll prepare a v3 addressing this myself (keeping you as the author).
>
>
> A-OK from my side, the abort_reset label is indeed redundant now.
>
> (The split between start and finish is also technically redundant when we always finish after start, but I wanted to keep the change minimal.)
Right actually for undoing the moving of the finish-reset
you could also have done a straight forward revert:
git revert af93a167eda9
My v3 is pretty close to this, but not exactly a full revert
since I kept your minimal approach.
Undoing the split however does not cleanly revert.
Regards,
Hans