Re: [PATCH] block: fix overflow in blk_ioctl_discard()

From: Christoph Hellwig
Date: Tue Apr 02 2024 - 08:32:57 EST


On Fri, Mar 29, 2024 at 09:23:19AM +0800, linan666@xxxxxxxxxxxxxxx wrote:
> From: Li Nan <linan122@xxxxxxxxxx>
>
> There is no check for overflow of 'start + len' in blk_ioctl_discard().
> Hung task occurs if submit an discard ioctl with the following param:
> start = 0x80000000000ff000, len = 0x8000000000fff000;
> Add the overflow validation now.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Can you wire up a testcase in blktests for this condition?