Re: [PATCH] ASoC: codecs: rk3308: add dependency on OF

[Luca Ceresoli]

Hello Mark,

On Tue, 2 Apr 2024 14:04:19 +0100
Mark Brown <broonie@xxxxxxxxxx> wrote:

> On Fri, Mar 29, 2024 at 09:44:47PM +0100, Luca Ceresoli wrote:
> 
> >  config SND_SOC_RK3308
> >  	tristate "Rockchip RK3308 audio CODEC"
> > +	depends on OF  
> 
> There's no actual build dependency on OF, please add an || COMPILE_TEST
> to improve build coverage and help maintainability.

I see, thanks for the comment.

While there, an even better improvement is probably:

  depends on ARM64 || COMPILE_TEST

using ARM64 because this codec is known to exist only on the RK3308 and
ARM64 selects OF.

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com