Re: [PATCH] scsi: qla2xxx: Fix off by one in qla_edif_app_getstats()

[Himanshu Madhani]

On 4/2/24 02:56, Dan Carpenter wrote:
> The app_reply->elem[] array is allocated earlier in this function and it
> has app_req.num_ports elements.  Thus this > comparison needs to be >=
> to prevent memory corruption.
>
> Fixes: 7878f22a2e03 ("scsi: qla2xxx: edif: Add getfcinfo and statistic bsgs")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
>   drivers/scsi/qla2xxx/qla_edif.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
> index 26e6b3e3af43..dcde55c8ee5d 100644
> --- a/drivers/scsi/qla2xxx/qla_edif.c
> +++ b/drivers/scsi/qla2xxx/qla_edif.c
> @@ -1100,7 +1100,7 @@ qla_edif_app_getstats(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
>   
>   		list_for_each_entry_safe(fcport, tf, &vha->vp_fcports, list) {
>   			if (fcport->edif.enable) {
> -				if (pcnt > app_req.num_ports)
> +				if (pcnt >= app_req.num_ports)
>   					break;
>   
>   				app_reply->elem[pcnt].rekey_count =


Looks good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani                                Oracle Linux Engineering