Re: [PATCH 6/7] dt-bindings: clock: qcom: Add GPUCC clocks for SM4450

[Ajit Pandey]

On 3/31/2024 2:00 PM, Krzysztof Kozlowski wrote:
> On 31/03/2024 10:18, Krzysztof Kozlowski wrote:
> > On 30/03/2024 19:28, Ajit Pandey wrote:
> > > Add support for qcom display clock controller bindings
> > > for SM4450 platform.
> > >
> > > Signed-off-by: Ajit Pandey <quic_ajipan@xxxxxxxxxxx>
> > > ---
> >
> > Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> Un-reviewed. I did not notice that this was not tested at all.
>
> NAK
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline), work on fork of kernel
> (don't, instead use mainline) or you ignore some maintainers (really
> don't). Just use b4 and everything should be fine, although remember
> about `b4 prep --auto-to-cc` if you added new patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time, thus I will skip this patch entirely till you follow
> the process allowing the patch to be tested.
>
> Please kindly resend and include all necessary To/Cc entries.
>
>
> Best regards,
> Krzysztof

Apologies somehow missed including device tree mailing list, Thanks for 
review and suggestion will take care of this in next series.
--
Thanks, and Regards
Ajit