Re: [PATCH 1/3] dt-bindings: leds: add LED_FUNCTION_FNLOCK

[Gergo Koteles]

Hi Krzysztof,

On Tue, 2024-04-02 at 20:08 +0200, Krzysztof Kozlowski wrote:
> On 02/04/2024 16:36, Gergo Koteles wrote:
> > Hi Krzysztof,
> > 
> > On Tue, 2024-04-02 at 15:55 +0200, Krzysztof Kozlowski wrote:
> > > 
> > > Do we really need to define all these possible LED functions? Please
> > > link to DTS user for this.
> > > 
> > 
> > I think for userspace it's easier to support an LED with a specified
> > name than to use various sysfs attributes. LED devices are easy to find
> > because they available are in the /sys/class/leds/ directory.
> > So I think it's a good thing to define LED names somewhere.
> 
> You did not add anything for user-space, but DT bindings. We do not keep
> here anything for user-space.
> 

The LED_FUNCTION_KBD_BACKLIGHT confused me. Ok, this shouldn't be here,
I will remove it from v2.

Thanks,
Gergo