Re: [PATCH 1/2] perf annotate: Get rid of duplicate --group option item

From: Arnaldo Carvalho de Melo
Date: Tue Apr 02 2024 - 16:40:18 EST


On Mon, Mar 25, 2024 at 09:56:50AM -0400, Liang, Kan wrote:
>
>
> On 2024-03-22 6:43 p.m., Namhyung Kim wrote:
> > The options array in cmd_annotate() has duplicate --group options. It
> > only needs one and let's get rid of the other.
> >
> > $ perf annotate -h 2>&1 | grep group
> > --group Show event group information together
> > --group Show event group information together
> >
> > Fixes: 7ebaf4890f63 ("perf annotate: Support '--group' option")
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>
> For the series,
>
> Reviewed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>

For 'b4' sake, next time please send the Reviewed-by to the cover letter
in the series so that it picks your Reviewed-by for all patches, not
just for the one that you replied to, as in this case.

I'm adding it to this whole series,

Thanks!

- Arnaldo