Re: [PATCH v4] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode

From: Mukesh Kumar Savaliya
Date: Wed Apr 03 2024 - 02:09:44 EST


Thanks Vinod and Andi !

It had time and also there was a comment to get sign off from DMA maintainers, we have had review and discussion on DMA part too.

Hi Vinod, Since this is already merged, do you have preference to revert OR making a new change if any BUG OR design issue ? I can also fix the changes you suggest and raise a new patch in case of any real bug OR design expectations.


On 4/2/2024 10:14 PM, Andi Shyti wrote:
Hi Vinod,

On Fri, Mar 29, 2024 at 10:15:24PM +0530, Vinod Koul wrote:
On 28-03-24, 08:36, Andi Shyti wrote:
Hi

On Wed, 13 Mar 2024 10:56:39 +0530, Mukesh Kumar Savaliya wrote:
I2C driver currently reports "DMA txn failed" error even though it's
NACK OR BUS_PROTO OR ARB_LOST. Detect NACK error when no device ACKs
on the bus instead of generic transfer failure which doesn't give any
specific clue.

Make Changes inside i2c driver callback handler function
i2c_gpi_cb_result() to parse these errors and make sure GSI driver
stores the error status during error interrupt.

[...]

Applied to i2c/i2c-host-next on

git://git.kernel.org/pub/scm/linux/kernel/git/local tree

You applied changes to dmaengine driver without my ack! I dont agree to
the approach here, we could do better

this must be an error from b4 ty. The changes have been added to

pub/scm/linux/kernel/git/andi.shyti/linux.git

branch i2c/i2c-host, As it has been agreed from very long.

Anyway, the changes are in -next. What do we do now? Do I revert
it? Mukesh, can you please agree with Vinod?

Andi