Re: [PATCH v3 5/9] platform/x86: asus-wmi: store a min default for ppt options

From: Luke Jones
Date: Wed Apr 03 2024 - 04:30:01 EST


On Wed, 3 Apr 2024, at 9:23 PM, Ilpo Järvinen wrote:
> On Wed, 3 Apr 2024, Luke D. Jones wrote:
>
> > Laptops with any of the ppt or nv tunables default to the minimum setting
> > on boot so we can safely assume a stored value is correct.
> >
> > This patch adds storing of those values in the local struct, and enables
> > reading of those values back. To prevent creating a series of byte holes
> > in the struct the "<name>_available" bool is removed and
> > `asus_sysfs_is_visible()` uses the `ASUS_WMI_DEVID_<name>` directly.
> >
> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> > Signed-off-by: Luke D. Jones <luke@xxxxxxxxxx>
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
>
> (I know it is already among the tags but I had not given it until now.)
>
> --
> i.
>

Understood, very sorry about making that assumption.

Luke.